-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling related question - huge amount of fixes to contribute. #124754
Comments
@ArieHein |
Not sure i follow you there. These are spelling mistakes across quite a lot of sub folders in the articles and the includes which will end up in over 50 pull requests if i split it per folder (probably more). I'm looking for insight on how to break it so its easier for you guys to review. |
@ArieHein |
Have the same issues with the sql-docs, with only 181 spelling fixes, but at least there, its over 7 main chapters, so opening 7 PRs isnt too much to "flood" the existing 6 requests. |
@ArieHein |
@TPavanBalaji I know the issues are going away but the pull requests are not. None of the documentation answers my questions so this is why i hoped to get some sort of support here. I have to say, so far this has been a very poor level of interaction. None of your comments actually deals with my questions and you end up closing the issue. @JasonWHowell, @thomps23 , Do you have any ideas about this topic to make it both easier for you to review (as you both are owners of at least half the chapters that i can see) and on the other hand not spam the pull request with 2 full pages ? |
@ArieHein We have automation for such things, so while we appreciate the help, it can be done in a fashion without requiring manual reviews by hundreds of individuals. If it's just a couple of words, it can be done in a batch by the automation. I'm not sure what you mean "chapters". Can you please clarify. Thanks, Jason |
@JasonWHowell Thank you for picking this up, appreicated. Chapters are the sub folders under the articles or includes top folders, for example 'azure-sql-edge', 'azure-vmware' as in the picture i have added here, are a chapter, for lack of better word. Sometimes, there would be maybe just one file that needs a change in a chapter, sometimes multiple, and sometimes more than one fix in the same file. Since i have about 100 of these chapters, that's 100 pull requests, which is why im looking for your insights into how to do it correctly. more examples: Original: "...build on thePpython apps..." Original: "...must be either connecticity or..." Hope this gives you a glimpse about the scale of this...i have weird hobbies over weekends :) |
That's a noble task. Thanks for the help. I think we have a conference coming up at Ignite starting Nov 19th, and a lot of content usually changes at conferences. I recommend waiting until after that time to start on any changes, else conflicts are likely to arise, and the changes rejected. Let's check with @Court72 on logistics of what she prefers since she's triaging most of the incoming pull requests. Since the changes are spelling typos then we likely don't require a major tech review to get things merged. More of a quick editorial look. I'd call those chapters "service-folders" - one Azure service per folder. There are 158 folders under /articles/ in azure-docs public repo, and 12 folders+1574 files under includes. Other azure-docs-* repos should be less complex (~10 folders or less a piece). As long as it's just simple spelling/typos, maybe it'd be sufficient to batch changes 10 (or 100?) files at a time per service-folder. What do you think @Court72 Thanks, Jason |
Thanks Jason, Usually what comes from ignite is an influx of NEW content to fix :) Luckily for me, or Courtney, not all service-folders require fixes to spelling or i would be worried :) |
I would still like @Court72 72 to weigh in on the PR file size. 10 is probably better than 100? |
Like i do at this time of the year, and already did to some of the documentation sites for tools and tech i use, its time for the spelling bee to contribute back...alas...I have gone over i think 20% of the entire rpeo, and have over 300 spelling fixes.
At this rate i will pass 1000 fixes.
Obviously i cant and wont send it all in one pull request.
Is there a specific way you would prefer me to split it, so you guys dont kill yourself for having to review too much at once ?
The text was updated successfully, but these errors were encountered: