Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference_time in single point time series #56

Open
jfigui opened this issue Dec 12, 2023 · 1 comment
Open

reference_time in single point time series #56

jfigui opened this issue Dec 12, 2023 · 1 comment

Comments

@jfigui
Copy link
Collaborator

jfigui commented Dec 12, 2023

@wolfidan
This discussion applies to process_grid_point in process_grid.py and process_point_measurement in process_timeseries.py.

In both functions there is an initialization step where a dictionary poi is added to the global_data (which is kept in memory). In this poi dictionary there is the point coordinates (lon, lat, alt), the exact time of acquisition of the data and a ref_time which is the volume or grid timestamp.
The reference time is updated every time a new radar volume (or grid) is ingested. When generating products from the resultant time series, the date (Ymd) of the reference time is used to create the directory and files where to store the data . Consequently plots cannot extend beyond one day, for every new day a new plot is started. This can be quite annoying when making time series plots that are only plotted at the end of the processing time because if they extend over 2 days only data from the second day is displayed. If for example the reference time is the end of the volume and the last volume ends at 00:00 UTC the next day, only this point is plotted.

The question is: should the reference time be updated only when the first volume is ingested?

@jfigui
Copy link
Collaborator Author

jfigui commented Dec 18, 2023

@wolfidan ,
as discussed I am going to add a variable start_time in the time series dictionary and add a setup variable that will allow the user to use start_time to define the folder and file name where to add the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant