Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circular dependency reporting to Metamaskbot comment #29740

Open
9 tasks
desi opened this issue Jan 15, 2025 · 0 comments
Open
9 tasks

Add circular dependency reporting to Metamaskbot comment #29740

desi opened this issue Jan 15, 2025 · 0 comments

Comments

@desi
Copy link
Contributor

desi commented Jan 15, 2025

What is this about?

Store a JSON snapshot of our circular deps and monitor changes through automated checks - similar to how we handle attributions.

  • Store snapshot in /madge-circular-deps.json, (we are codeowners)
  • Use 'yarn circular-deps:update' to generate
  • Use 'yarn circular-deps:check' to validate
  • Integrate with existing GitHub workflows (metamaskbot, etc)

This gives us visibility into any circular dependency changes before they hit our codebase. We'll be able to:

  • Track changes in real-time
  • See exactly what code changes triggered new circular deps
  • Keep a clear history of how these dependencies evolve

It's a simple start, but it'll help us make more informed decisions about our dependency structure.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

  • We can track changes over time and see where problems started.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant