Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give meltano engineering team write access to all repos #21

Open
3 tasks
pnadolny13 opened this issue Sep 29, 2022 · 3 comments
Open
3 tasks

Give meltano engineering team write access to all repos #21

pnadolny13 opened this issue Sep 29, 2022 · 3 comments
Assignees

Comments

@pnadolny13
Copy link
Contributor

pnadolny13 commented Sep 29, 2022

We've been giving Meltano core engineers repo access on a one off basis by adding them to the repo specific Github teams. It also looks like theres inconsistent levels of access for the repo teams (some write and some maintainers).

Should we give the meltano engineering team maintainer access to all repos to avoid this one off permission setting? Then it might make sense to have all repo teams be consistently write level access and not maintainer.

@WillDaSilva raised a point to consider - that we might not want to do this to avoid fall out if an account is compromised. It's probably a tradeoff we want to weigh. Either simpler maintenance for engineering team for on/offboarding or higher security in case of compromise but harder to manage on/offboarding.

@aaronsteers @WillDaSilva @kgpayne what do you think?

Proposed

@pnadolny13 pnadolny13 changed the title Should we give engineering access to all repos? Should we give meltano engineering team access to all repos? Sep 29, 2022
@WillDaSilva
Copy link

Context from Slack: https://meltano.slack.com/archives/C03GKHWS0HM/p1664456467035269?thread_ts=1664450851.731359&cid=C03GKHWS0HM

@pnadolny13
Copy link
Contributor Author

@WillDaSilva I added your point around limiting fall out to the description above.

@aaronsteers
Copy link

@pnadolny13 - In the context of MeltanoLabs, yes, I agree we can give the Meltano Team "Write" on all repos.

@pnadolny13 pnadolny13 changed the title Should we give meltano engineering team access to all repos? Give meltano engineering team write access to all repos Sep 29, 2022
@pnadolny13 pnadolny13 self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants