Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some models don't export valid VRMs (Uint32Array multiple of 4) #66

Open
madjin opened this issue Nov 14, 2023 · 5 comments
Open

Some models don't export valid VRMs (Uint32Array multiple of 4) #66

madjin opened this issue Nov 14, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@madjin
Copy link
Member

madjin commented Nov 14, 2023

I notice it just hangs when importing to hyperfy or https://vrm-validator.fern.solutions/, tried all the different options for atlas
image
@madjin madjin added the bug Something isn't working label Nov 14, 2023
@madjin
Copy link
Member Author

madjin commented Nov 14, 2023

sample: https://cdn.discordapp.com/attachments/1041270464271622234/1174094857300611144/291_WIP.vrm?ex=6566580b&is=6553e30b&hm=198c42361d3e4c4e34db508fd59ac016d34fcdf20d88ba06d0bc1eba4376fcdd&

@madjin
Copy link
Member Author

madjin commented Nov 14, 2023

image
122: https://cdn.discordapp.com/attachments/1041270464271622234/1174096081169154171/122_WIP.vrm?ex=6566592f&is=6553e42f&hm=43a390c8115aff0919d831824cc3985476ff8ed8e79579b73c0448e09884f499&

@lalalune lalalune modified the milestone: MVP Dec 4, 2023
@madjin madjin changed the title Optimization: Some models don't export valid VRMs Some models don't export valid VRMs (Uint32Array multiple of 4) Dec 12, 2023
@madjin
Copy link
Member Author

madjin commented Dec 12, 2023

Tested with anata-merge and main branch, getting similar error
https://cdn.discordapp.com/attachments/1041270464271622234/1183961016724377712/1.zip?ex=658a3c9f&is=6577c79f&hm=6c24299405bd123babf0975d80b8609bd4d60b9b0294869a39a6e26ec5fd415a&

@memelotsqui
Copy link
Collaborator

memelotsqui commented Dec 12, 2023 •
edited
Loading

image
probably the error is happening somewhere around lines 273 and 318 in VRMExporterV0.js, when saving sparse accessor data im probably missing to set correctly 4 byte boundery

@madjin
Copy link
Member Author

madjin commented Dec 12, 2023

just tested 1558 and it seems like some with no atlas option selected are also producing this error, HOWEVER it is still able to load in hyperfy. (shown below is no atlas)
image
image

but the one that doesn't produce this error throws an error and won't load (shown below is with atlas)
image
image

@memelotsqui memelotsqui mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@memelotsqui @lalalune @madjin