Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #146 내 패널티 정보 조회 수정 #146

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

huncozyboy
Copy link
Member

PR 내용

#145
본인(특정 Id) 패널티 조회에서 모든 패널티가 조회되는 문제를 수정했습니다

PR 세부사항

PenaltyUsecaseImpl에서 본인 패널티 조회시 기존에 있던 userId를 사용하는 올바른 findAll 메서드를
사용하도록 수정했습니다

관련 스크린샷

image
image


주의사항

조회하는 유저의 패널티와 다른 유저의 패널티 더미데이터로 넣어놓고 테스트 완료했습니다

체크 리스트

  • 리뷰어 설정
  • Assignee 설정
  • Label 설정
  • 제목 양식 맞췄나요? (ex. #0 Feat: 기능 추가)
  • 변경 사항에 대한 테스트

@huncozyboy huncozyboy added the fix label Feb 18, 2025
@huncozyboy huncozyboy requested review from hyxklee and jj0526 February 18, 2025 15:16
@huncozyboy huncozyboy self-assigned this Feb 18, 2025
@huncozyboy huncozyboy linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link
Collaborator

@jj0526 jj0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 유저가 가진 패널티 조회로 변경 확인했습니다!!

Copy link
Member

@hyxklee hyxklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 고생하셨습미다

@huncozyboy huncozyboy merged commit a20df57 into develop Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix #145 내 패널티 정보 조회 수정
3 participants