Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] create state$ and input$ base on callback length #57

Open
crimx opened this issue Jul 8, 2019 · 0 comments
Open

[performance] create state$ and input$ base on callback length #57

crimx opened this issue Jul 8, 2019 · 0 comments
Assignees

Comments

@crimx
Copy link

crimx commented Jul 8, 2019

Currently Subject state$ and input$ are always created. How about checking the length of the callback argument and only create the Subjects that are used by the callback.

One caveat of this approach is the length check does not recognize spread arguments and the use of arguments object. But I think it is rare to use callback this way.

@Brooooooklyn Brooooooklyn self-assigned this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants