[BUG] Shape Variant permissions

[rexy712]

Describe the bug
I want to give a player access to different variants on a shape for their wildshaping druid. Ideally they could change their variant themselves without the DM having to interfere. I realized that each variant has separate permissions, so I gave them edit permissions on both variants. They were able to change the variant, sort of. When doing so, the server logs spit out the line:

WARNING - Attempt by ${player_name} on shape they do not own. {method: ToggleComposite.Variants.Active.Set, shape id: ...} (utils.py:20).

Sometimes the variant is changed, but not seen by others until they interact with it (eg moving the shape). Sometimes the visuals update but not the state of the variant in the properties window. We also saw an issue of variants "escaping" from the shape to become their own separate shape. After a player changes to another variant, the GM moves the shape, then the GM changes the variant. An "escaped" variant appears where the shape was moved from.

To Reproduce
Steps to reproduce the behavior:

1. Create a shape with at least 1 variant
2. Give full access to the shape to another player for both variants
3. Have the player change which is the active variant
4. Changes are not seen initially. Other strange bugs can occur.
5. GM moves the shape on the board.
6. GM changes the variant of the shape.
7. An "escaped" variant appears where the shape was moved from.

Expected behavior
I think that having the permissions tied to each separate variant is probably not correct. I think that permissions should be on a shape-by-shape basis, including each of its variants since it still represents the same 'thing'. Having the permissions differ on variants seems like an odd behavior.

Nonetheless, if permissions differing between variants is supposed to be how it works, then the expected behavior is: When a player has edit permissions on each variant, there should be no issue with them changing it just as a DM can.

Screenshots

Player on the left, GM on the right. Player has full permissions on both variants. This was me experimenting before I knew what caused the variant "escape" behavior.

variant-bug.mp4

Desktop:

• OS: gentoo linux
• Browser: ungoogled-chromium-130.0.6723.116, firefox-132.0.2
• Version: dev branch commit 39eea47

[Kruptein]

I'm not surprised.

Variants are a headache due to them being a combination of a bunch of shapes.

Access should be managed/copied on the parent shape and currently is purely shape specific probably.

I'll look into the escaped shapes.