Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting rescale! from MLDataUtils ? #128

Open
theogf opened this issue Nov 4, 2022 · 3 comments
Open

Porting rescale! from MLDataUtils ? #128

theogf opened this issue Nov 4, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@theogf
Copy link

theogf commented Nov 4, 2022

I saw in #17 that rescale! would not be ported. What is the reason? It's an extremely practical tool to not only preprocess your data but also be able to scale back some of the predictions you get...

@ToucheSir
Copy link
Contributor

Part of the motivation is that APIs like https://juliaml.github.io/TableTransforms.jl/stable/transforms/builtin/#TableTransforms.Scale and https://invenia.github.io/FeatureTransforms.jl/stable/api/#FeatureTransforms.StandardScaling already exist. It doesn't make a lot of sense to reinvent the wheel there, especially since you'd have to maintain it going forwards (which is part of what killed MLDataUtils development velocity).

@theogf
Copy link
Author

theogf commented Nov 4, 2022

Thanks for the explanation! Maybe that would be good to refer to these packages for people who want to migrate from MLDataUtils ?

@ToucheSir ToucheSir added the documentation Improvements or additions to documentation label Nov 4, 2022
@ToucheSir
Copy link
Contributor

Good idea! Added the relevant label so this doesn't go forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants