Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed geometric integrators from dependencies. #181

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

benedict-96
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (329b083) to head (e75cdca).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   66.97%   64.38%   -2.59%     
==========================================
  Files         123      119       -4     
  Lines        3736     3695      -41     
==========================================
- Hits         2502     2379     -123     
- Misses       1234     1316      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96
Copy link
Collaborator Author

I opened two new issues concerning re-implementation of stuff that is removed in this pr:

  1. Extend HODEProblem constructor to Hamiltonian neural network #182
  2. Interface for SympNet to work with GeometricIntegrators #183

@michakraus michakraus merged commit cde4d3f into main Dec 12, 2024
9 of 13 checks passed
@michakraus michakraus deleted the remove-gi branch December 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants