Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy matching for journal abbreviations #12467

Open
Enivex opened this issue Feb 5, 2025 · 7 comments · May be fixed by #12477
Open

Fuzzy matching for journal abbreviations #12467

Enivex opened this issue Feb 5, 2025 · 7 comments · May be fixed by #12477
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: journal abbreviations good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@Enivex
Copy link

Enivex commented Feb 5, 2025

Is your suggestion for improvement related to a problem? Please describe.
Often, the journal abbreviation feature will do nothing because there is a slight difference in the full journal name. Such as capitalization, use of punctuation, or subtitles.

Describe the solution you'd like
I want to be able to use fuzzy matching, ignoring minor differences like this.

Additional context
Add any other context or screenshots about the feature request here.

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 6, 2025
@arraymahdi
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

👋 Hey @arraymahdi, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 07 May 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@arraymahdi
Copy link

Could you please clarify which search you intended to add the fuzzy matching to— the web search or the search within the imported articles? I just want to make sure I understand correctly. 😊

@Enivex
Copy link
Author

Enivex commented Feb 6, 2025

The search used to match the journal in the journal field to an entry in the list of journal abbreviations

@arraymahdi
Copy link

Excuse me, could you kindly share a screenshot to help me? I haven't used the app before. If you could guide me to the search feature, I'll take it from there. Thanks so much in advance! 😊

Image

@Enivex
Copy link
Author

Enivex commented Feb 6, 2025

Quality -> Abbreviate journal names in the menu bar

@arraymahdi
Copy link

arraymahdi commented Feb 9, 2025

Hi,
Is the current level of tolerance sufficient, or should I make it more lenient?

 @Test
    void testSlightDifferences() {
        assertTrue(new Abbreviation("Long Name", "L. N.").isSimilar("Longn Name"));
    }

    @Test
    void testMissingLetter() {
        assertTrue(new Abbreviation("Long Name", "L. N.").isSimilar("Long ame"));
    }

    @Test
    void testPunctuationDifferences() {
        assertTrue(new Abbreviation("Long Name", "L. N.").isSimilar("Long, Name"));
    }

    @Test
    void testCaseDifferences() {
        assertTrue(new Abbreviation("Long Name", "L. N.").isSimilar("LONG NAME"));
    }

@arraymahdi arraymahdi linked a pull request Feb 10, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: journal abbreviations good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Free to take
Status: Free to take
Development

Successfully merging a pull request may close this issue.

3 participants