Fail bundle install if a formula is installed but not linked

[andreineculau]

We have a situation where people install software outside of homebrew, and running brew bundle install will install the formulae but then fail creating the symlinks. Trying again though will succeed, although the symlinks are not enabled, thus hiding the problem.

At least my expectation is that brew bundle install is deterministic.
No problems: we installed AND linked n formulae.
Problems: we installed n but failed to link m formulae.

Right now it's not. Either there are no problems, or if there are, trying again and again and again will lead to a success message, with problems being ignored.

[jacobbednarz]

if i understand this correctly, this is less of a bundle problem and more of a brew + overwriting problem. what does the bundle file look like? what arguments are you passing in? what is the PATH setup on these systems?

[MikeMcQuaid]

Can you provide a minimal Brewfile and, ideally, brew commands that reproduce this behaviour?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[yelsa]

@MikeMcQuaid i think this got fixed by 37f0345

If I understand the OP was after the failure messaging to be fixed, so that failure to link is a homebrew-bundle failure.

It is similar to the two examples in #1442 where linking fails but a success message is still printed and the exit code is 0. The underlying problem there was that success was based only on if the install step was successfull, and it ignored any link (or service state change) failures. That is what your commit changed.

[MikeMcQuaid]

i think this got fixed by 37f0345

Yes, quite likely, thanks for chiming in.