Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Report: The table data is not sorted #996

Open
max-ostapenko opened this issue Jan 14, 2025 · 4 comments · May be fixed by #934
Open

Tech Report: The table data is not sorted #996

max-ostapenko opened this issue Jan 14, 2025 · 4 comments · May be fixed by #934
Assignees
Labels
Tech Report HTTP Archive Technology Report

Comments

@max-ostapenko
Copy link
Contributor

max-ostapenko commented Jan 14, 2025

https://httparchive.org/reports/techreport/drilldown?tech=Astra&geo=ALL&rank=Top+10k&client=desktop#adoption

@rviscomi Have we ever had it sorted before?

Image
@rviscomi
Copy link
Member

Seems like a new bug

@max-ostapenko
Copy link
Contributor Author

I can try to adjust Firestore to have it sorted in response.
@sarahfossheim will it save us from re-sorting it again on the client?

@rviscomi rviscomi added the Tech Report HTTP Archive Technology Report label Jan 15, 2025
@sarahfossheim
Copy link
Collaborator

I think sorting it in the response might fix it yes! But I'll look into what's causing it anyway, might be a new client-side bug as well.

@sarahfossheim sarahfossheim linked a pull request Jan 16, 2025 that will close this issue
@sarahfossheim
Copy link
Collaborator

This is fixed in the front-end in the open PR (#934) in the client side, but the API response is unsorted. Uncertain if it always was returned in random order and we just didn't notice it before, or if at some point the response sorting stopped working.

Behavior client

https://technology-report-dot-httparchive.uk.r.appspot.com/reports/techreport/drilldown?tech=Astra&geo=ALL&rank=Top+10k&client=desktop#adoption

Table sorted from 2024-12-01 to 2024-06-01

API response

https://prod-gw-2vzgiib6.ue.gateway.dev/v1/adoption?technology=ALL&geo=ALL&rank=Top%2010k

[
    {
        "technology": "ALL",
        "geo": "ALL",
        "date": "2024-10-01",
        "rank": "Top 10k",
        "adoption": {
            "mobile": 7771,
            "desktop": 6452
        }
    },
    {
        "technology": "ALL",
        "date": "2023-12-01",
        "geo": "ALL",
        "rank": "Top 10k",
        "adoption": {
            "mobile": 7965,
            "desktop": 6502
        }
    },
    {
        "technology": "ALL",
        "date": "2022-07-01",
        ...
    },
    {
        "technology": "ALL",
        "date": "2024-01-01",
        ...
    },
    {
        "technology": "ALL",
        "date": "2023-09-01",
        ...
    },
    {
        "technology": "ALL",
        "date": "2022-10-01",
        ...
    },
    {
        "technology": "ALL",
        "date": "2022-03-01",
        ...
    },
    ...
}

@max-ostapenko @rviscomi

@sarahfossheim sarahfossheim linked a pull request Jan 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Report HTTP Archive Technology Report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants