Simplify ITenantInfo?

[fdcastel]

1. Why does ITenantInfo have property setters?

   To the best of my understanding, they are only used in tests.

   ITenantInfo interface could be simplified to use only getters. And tests may use a TestTenantInfo with setters.

2. While on this page, why Identifier and Name?

   The absolutely minimum required is Id. And it should not be nullable.

   Other properties seem to be used only for some specific cases/strategies. It could be refactored.

Sadly, the 7.0 release has already shipped. Maybe in 8.0?

I can work on some PRs, if interested.

[fdcastel]

Update:

To the best of my understanding, they are only used in tests.

Correction: The interface setters are not used anywhere. Tests always use TenantInfo class, which already does have setters.

ITenantInfo interface can be simplified to use only getters.

I did a POC right now in a local fork and everything builds fine.
I can provide my own custom ITenantInfo implementation without the need for setters.

[AndrewTriesToCode]

Yes you are right. I would like to clean this up on the next major release and have ITenantInfo instances be treated more like an immutable.