Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__isProxy property should not be enumerable (IE11 issue) #31

Open
ElliotNB opened this issue Jul 4, 2019 · 3 comments
Open

__isProxy property should not be enumerable (IE11 issue) #31

ElliotNB opened this issue Jul 4, 2019 · 3 comments
Assignees
Labels

Comments

@ElliotNB
Copy link
Owner

ElliotNB commented Jul 4, 2019

In IE11, __isProxy is enumerable when iterating over an object's properties like this:

for (var requiredField in this.data.missing_fields) {

It should not be enumerable.

@Rezyan
Copy link
Contributor

Rezyan commented Apr 1, 2022

@ElliotNB I will be working on this issue soon.

@ElliotNB
Copy link
Owner Author

ElliotNB commented Apr 1, 2022

@brokensourcecode Sounds great, thanks for the heads up! For this particular issue, I believe it was only impacting IE11 so for testing that'll require IE11, the proxy.min.js polyfill included, etc. If it's possible to create a unit test that replicates the error and to demonstrate that the fix is working afterwards, that would also be fantastic. With this library I try to be as TDD as possible 8)

@Rezyan
Copy link
Contributor

Rezyan commented Apr 1, 2022

@ElliotNB If this issue is only on IE11, I invite you to read my message here: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants