Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue, but feature request. #225

Open
JimLindsey opened this issue Apr 29, 2021 · 4 comments
Open

Not an issue, but feature request. #225

JimLindsey opened this issue Apr 29, 2021 · 4 comments

Comments

@JimLindsey
Copy link

The latest update looks great. Would it be possible to add a third option to the light / dark modes? Specifically, the [i]previous[/i] dark theme - as in attached picture.

Great utility.

current_systems

@SayakMukhopadhyay
Copy link
Member

Any particular reason why you would want the third option?

@JimLindsey
Copy link
Author

JimLindsey commented May 1, 2021

It is easier on my eyes; (side_by_side.png)
Also I think it goes better with some of the other utilities I normally have open at any given time, (from my perspective anyway), while flying around the Elite Dangerous galaxy. (old_theme.png) (new_dark.png)

Just a feature request, I understand this project is done on your time.

side_by_side
old_theme
new_dark

@SayakMukhopadhyay
Copy link
Member

Hmm, I get you. Although there is a little problem of how do we control switching between 3 themes. Right now, its a 2 way toggle.
Right now, the theme selection is saved in your browser so the theme will be light when you access through a new browser. One way this can be handled is by using the system theme as default and only allowing logged in users to set a custom theme. This way the theme selection is stored in your user account. This is how its handled in GitHub for example.
Give me some time to ponder on this and maybe ask for feedback in my Discord server.

@SayakMukhopadhyay
Copy link
Member

As I said this feature will require some core changes in how themes are handled and the above PR is a start of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants