-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the selenuim web driver used to run javascript tests #143
Comments
prusse-martin
changed the title
Update the selenuim driver used to run javascript tests
Update the selenuim webdriver used to run javascript tests
Sep 19, 2022
prusse-martin
changed the title
Update the selenuim webdriver used to run javascript tests
Update the selenuim web driver used to run javascript tests
Sep 19, 2022
I personally do like the trailing commas =) it looks good. |
Did #142 fixed this? |
Give we can update prettier an have if working with phantomjs, yes. But it will really be nice to be able to use modern javascript syntax and features and phantomjs is not being updated: |
Ahh my bad, this is about updating the driver... had too many tabs open and got confused hehehe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After updating "prettier" pre-commit hook to "v3.0.0-alpha.0" PhantomJS started to fail parsing the javascript source due new trailing commas, the command line option
--trailing-comma=none
will avoid that.We need:
- or find out how to pass the trailing-comma flag via pre-commit hook;- or keep living using "prettier 2.7.1";The trailing-comma option is being passed using the
.prettierrc
file.Updating is relevant because newer qt support more recent javascript syntax support that can't be properly used because PhantomJS does not support it.
The text was updated successfully, but these errors were encountered: