Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transclusion_reference #489

Open
alfredsgenkins opened this issue Mar 10, 2022 · 2 comments
Open

Add support for transclusion_reference #489

alfredsgenkins opened this issue Mar 10, 2022 · 2 comments

Comments

@alfredsgenkins
Copy link

alfredsgenkins commented Mar 10, 2022

Is your feature request related to a problem? Please describe.
I can not reference the transclusion_reference type block. When I do it, the following error is displayed:

Block type is not of the supported types
Given type: transclusion_reference

Describe the solution you'd like
I would like to get support for this block, the @nishan/types already has all typing for it, the @nishan/core seems to be out of date.

Additional context
I have the following dependencies specified in my application:

"@nishans/core": "^0.0.35",
"@nishans/types": "^0.0.57",

The example of code, which may cause this issue:

const syncedBlocks = await page.getBlocks((block) => block.type.includes('transclusion'), true);

Please note, the page should include the synced block on it to throw this error.

@alfredsgenkins
Copy link
Author

I have fixed it temporarily, by modifying the node_modules/@nishans/core/node_modules/@nishans/constants/dist/libs/blockTypes.js to include transclusion_reference and transclusion_container.

@Devorein
Copy link
Owner

Hey, thank you for raising the issue. I've been super busy with my academics and work so can't give an exact deadline on when this will be implemented. I'm glad that you managed to figure out the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants