From b5123c2445dfa6b2c64420b9d46f5df3eaccdc17 Mon Sep 17 00:00:00 2001 From: DevEmperor <56255079+devemperor@users.noreply.github.com> Date: Fri, 2 Feb 2024 12:48:34 +0100 Subject: [PATCH] db optimization --- .../wristassist/database/ChatHistoryDatabaseHelper.java | 4 +--- .../devemperor/wristassist/database/UsageDatabaseHelper.java | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/net/devemperor/wristassist/database/ChatHistoryDatabaseHelper.java b/app/src/main/java/net/devemperor/wristassist/database/ChatHistoryDatabaseHelper.java index 8b7a5f3..45308df 100644 --- a/app/src/main/java/net/devemperor/wristassist/database/ChatHistoryDatabaseHelper.java +++ b/app/src/main/java/net/devemperor/wristassist/database/ChatHistoryDatabaseHelper.java @@ -125,9 +125,7 @@ public void edit(Context context, long id, ChatItem item) throws IOException, JS public void delete(Context context, long id) { SQLiteDatabase db = this.getWritableDatabase(); - Cursor cursor = db.rawQuery("DELETE FROM CHAT_HISTORY_TABLE WHERE ID=" + id, null); - cursor.moveToFirst(); - cursor.close(); + db.delete("CHAT_HISTORY_TABLE", "ID=" + id, null); db.close(); String filePath = context.getFilesDir().getAbsolutePath() + "/chat_" + id + ".json"; diff --git a/app/src/main/java/net/devemperor/wristassist/database/UsageDatabaseHelper.java b/app/src/main/java/net/devemperor/wristassist/database/UsageDatabaseHelper.java index de1b7ed..904d74b 100644 --- a/app/src/main/java/net/devemperor/wristassist/database/UsageDatabaseHelper.java +++ b/app/src/main/java/net/devemperor/wristassist/database/UsageDatabaseHelper.java @@ -64,7 +64,7 @@ public void reset() { } public List getAll() { - SQLiteDatabase db = this.getWritableDatabase(); + SQLiteDatabase db = this.getReadableDatabase(); Cursor cursor = db.rawQuery("SELECT * FROM USAGE", null); List models = new ArrayList<>(); @@ -79,7 +79,7 @@ public List getAll() { } public double getTotalCost() { - SQLiteDatabase db = this.getWritableDatabase(); + SQLiteDatabase db = this.getReadableDatabase(); Cursor cursor = db.rawQuery("SELECT SUM(COST) FROM USAGE", null); double totalCost = 0;