Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace firework effect from all spells with particles #408

Open
riddle opened this issue Apr 14, 2015 · 1 comment
Open

Replace firework effect from all spells with particles #408

riddle opened this issue Apr 14, 2015 · 1 comment
Labels

Comments

@riddle
Copy link
Member

riddle commented Apr 14, 2015

With 1.8 and /particle it’s now easier to summon particles than before. I’d like to start using them for spells, as they’re more interesting than fireworks.

  • Forging, Smithing: flame †‡
  • Unsliming: slime
  • Peddling: magicCrit
  • Fusing, Allure: crit
  • Decay: witchMagic
  • Growth: happyVillager
  • Time: enchantmenttable
  • Wind: explode
  • Grazing: no particle for now
  • Pruning: no particle for now

† – either around the player or around the affected chest
‡ – a few particles so it looks good
¶ – around the player in a circular shape (~10 particles, 2 blocks away)

@riddle riddle added the Spells label Apr 14, 2015
matejdro added a commit that referenced this issue Apr 17, 2015
@riddle
Copy link
Member Author

riddle commented Apr 17, 2015

Reopening with notes from Slack:

Circle should appear only on spells which affect area around you: Allure, Growth, Decay, Unsliming (and Grazing and Pruning, once they get an effect).

The rest should be about concentrating the particle effect on the thing that was affected by the spell using a dot of multiple particles. A small ball of sorts, if you will.

Spells which affect a chest should display that dot in the middle of such chest. Single chest = middle of the clicked block. Double chest = in between chest blocks.

Spell which affect your inventory (Time or others when they aren’t targetting a chest) should display that dot in front of you, so you can see it. Yes, it can obscure the screen a bit.

Spell which affect other things (Peddling) should display the dot on that thing, slightly offset to be in front of the thing. So in case of Peddling it willl appear immediately before the villager.

@riddle riddle reopened this Apr 17, 2015
matejdro added a commit that referenced this issue Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant