-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spell error #354
Comments
Not exactly sure what caused this. I made possible fix, reopen if it happens again. |
|
Anything above? From what I saw this means something is wrong with required item config, but it should display reason before error. |
|
Spell of Peddling mentioned above is isolated only to this one chat log, nothing in 4 other cases. |
@eliadil any idea? https://github.com/CoreNetwork/Mantle/blob/master/src/main/java/us/corenetwork/mantle/spellbooks/Spellbook.java#L86 I think I'm missing something obvious. |
Is the error above recent? When this issue was created line 86 was something else. |
Those errors stopped at 24th of March as you can see above. We can close it and reopen if we ever see it again? |
Check riddle's screenshot above, last error was 24th march. I don't think we changed spells in that time. |
Ive seen the screen, but is th e pasted error from 24th or is it earlier one. |
@riddle I wouldn't say it is gone. Based on your screenshot it looks like error is very rare (occurring every few weeks), so it simply hasn't occurred yet since 24th. |
Oh look, an error from 24th
-.- |
Maybe it happens when the nbt on the item (days left) is updated? |
NBT updating has nothing to do with it (it is handled only serverside). Your new error points to item in hand being null. But how can that happen if player just used the book (which is in his hand)? |
How is it only server side if text on my book changes from time to time..? Something changes, item changes. |
Oops I meant clientside. |
But the text is decided by the server. So its both. |
Yeah but it is decided via ProtocolLib so technically we never operate with dynamic day item. |
Ginaw noticed it in console, I don’t have more details.
The text was updated successfully, but these errors were encountered: