Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] StatusBarBehavior does not occupy entire notch - fix #2309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[iOS] StatusBarBehavior does not occupy entire notch - fix #2309

wants to merge 1 commit into from

Conversation

kubaflo
Copy link

@kubaflo kubaflo commented Oct 30, 2024 •
edited by brminnick
Loading

Description of Change

I've encountered this bug while working with MAUI: dotnet/maui#24972 and it turns out that it is rather an issue that should be linked to this repository.

Basically the status bar is wrong for some screens. I've found this comments here: https://forums.developer.apple.com/forums/thread/662466

Screenshot 2024-10-30 at 19 33 40

It makes sense because when I based the status bar height on the top safe area I have the following result:

Expected Before After

Linked Issues

It might also fix this one: dotnet/maui#25435, but I'm not 100% sure if it is a status bar's or MAUI's issue. Maybe even both

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@kubaflo kubaflo mentioned this pull request Oct 30, 2024
Closed
pictos
pictos previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brminnick
Copy link
Collaborator

brminnick commented Oct 30, 2024 •
edited
Loading

The StatusBar overlaps the navigation bar in the After photo.

To help visualize this, I've added a green bar in the photo below that is the same height as the NavigationBar. The green bar is the same height in both the Before and After image.

Screenshot 2024-10-30 at 11 56 09 AM

brminnick
brminnick requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@brminnick brminnick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to a bug (or open a new Issue) in our GitHub repo to help us understand + reproduce the problem you are trying to fix.

Please also update edit the title of this PR; Improve status bar does not explain the bug or the proposed solution.

Please ensure the status bar does not overlap the navigation bar

Screenshot 2024-10-30 at 11 56 09 AM

@brminnick brminnick dismissed pictos’s stale review October 30, 2024 19:01

This PR increases the size of the StatusBar where it now overlaps the NavigationBar

@kubaflo
Copy link
Author

kubaflo commented Oct 30, 2024

Please link to a bug (or open a new Issue) in our GitHub repo to help us understand + reproduce the problem you are trying to fix.

Please also update edit the title of this PR; Improve status bar does not explain the bug or the proposed solution.

Please ensure the status bar does not overlap the navigation bar

Screenshot 2024-10-30 at 11 56 09 AM

Yea, but it is the iOS's native behaviour. Generally status bar should have the same color as the navigation bar. The only point for customising it is when we don't have a navigation bar. And the current MCT solution would give the following outcome:

Screenshot 2024-10-30 at 20 09 22

@Axemasta
Copy link
Contributor

Please link to a bug (or open a new Issue) in our GitHub repo to help us understand + reproduce the problem you are trying to fix.

This is the issue #2287, Originally I thought it was a maui issue but its not and actually a status bar behaviour issue, since the repro app doesn't apply the padding when not using the behavior

@kubaflo kubaflo changed the title [iOS] Improve status bar [iOS] StatusBarBehavior does not occupy entire notch for modal pages when NavigationPage.HasNavigationBar="False" - fix Oct 30, 2024
@kubaflo kubaflo changed the title [iOS] StatusBarBehavior does not occupy entire notch for modal pages when NavigationPage.HasNavigationBar="False" - fix [iOS] StatusBarBehavior does not occupy entire notch - fix Oct 30, 2024
@jfversluis
Copy link
Member

Another report of this bug: dotnet/maui#25435

Additionally I also ran into this myself while working on the https://github.com/jfversluis/blazor-hybrid-workshop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick requested changes

@pictos pictos pictos left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kubaflo @brminnick @Axemasta @jfversluis @pictos