Fix Windows Media Element in MultiWindow Mode on exit Crash #2259
Conversation
Added a static `NumberOfWindows` property to the `Options` class to track the number of windows. Updated `SetShouldEnableSnackbarOnWindows` to increment/decrement `NumberOfWindows` on window creation/closure. Conditional registration/unregistration of `AppNotificationManager` for snackbar notifications based on `NumberOfWindows` count.
src/CommunityToolkit.Maui/Options.cs
Outdated
| @@ -66,13 +66,25 @@ public void SetShouldEnableSnackbarOnWindows(bool value) | |||
| builder.ConfigureLifecycleEvents(events => | |||
| { | |||
| events.AddWindows(windows => windows | |||
| .OnWindowCreated((_) => | |||
| { | |||
| NumberOfWindows++; | |||
There was a problem hiding this comment.
I'm not sure if just the UIThread can create an window or if can be done by another thread. I believe that's the second, so the Window1.UIThread != Window2.UIThread, and that can cause concurrency issues.
I would suggest to use the Interlocked.Increment and Interlocked.Decrement to control this counter
There was a problem hiding this comment.
Good catch! Interlocked.Increment and Interlocked.Decrement are perfect for this scenario.
In this implementation, I think we should actually remove internal static int NumberOfWindows { get; private set; } and use Application.Current.Windows.Count to avoid creating a duplicate property forcing CommunityToolkit.Maui to increment/decrement properly.
I don't see a problem removing internal static in Options.NumberOfWindows { get; } since it is not being used anywhere else in the code.
I'll update the code to remove this property 👍
Description of Change
Track window count and manage snackbar notifications
Added a static
NumberOfWindowsproperty to theOptionsclass to track the number of windows. UpdatedSetShouldEnableSnackbarOnWindowsto increment/decrementNumberOfWindowson window creation/closure. Conditional registration/unregistration ofAppNotificationManagerfor snackbar notifications based onNumberOfWindowscount.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This PR uses a simple counter to track the number of windows that exist and only when one is remaining will it unregister Snackview