Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DrawingView.GetImageStream Size has no affect #1397

Open
2 tasks done
dapug opened this issue Sep 9, 2023 · 9 comments · May be fixed by #2193
Open
2 tasks done

DrawingView.GetImageStream Size has no affect #1397

dapug opened this issue Sep 9, 2023 · 9 comments · May be fixed by #2193
Assignees
@bijington
Labels
area/views Issue/Discussion/PR that has to do with Views bug Something isn't working

Comments

@dapug
Copy link

dapug commented Sep 9, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

Current Behavior

Size of an image cannot be set using DrawingView.GetImageBytes(). No matter what value you give in the Size param, the behavior is the same. The image stream does not size the image to the given size, and it is ALWAYS "shrink-to-fit" the actual dimensions of the drawn lines (whatever that size is), rather than the specified size.

Expected Behavior

EXPECTED:
Here is the 200x200 control with a small dark blue shape drawn in the middle. The image stream (or saved file) should appear like this:
image

Actual:
Here is the result of the stream (or saved file) after GetImageBytes() is processed:
image

Steps To Reproduce

  1. Add a DrawingView onto a Xaml page
  2. Set HeightRequest="200" WidthRequest="200"
  3. Add a DrawingLineCompleted method
  4. In the method, capture the lines that were drawn, and specify the same 200x200 size
    var dvStream = await DrawingView.GetImageStream(drawView.Lines, new Size(200,200), Colors.LightBlue);
  5. Add code to stream that image back to another control on page, or save to an image file on disk
  6. Run the app and draw a small shape on the canvas (something only 10-20px wide)
  7. Look at the resulting image

Link to public reproduction project repository

https://github.com/dapug/DrawingDemo

Environment

- .NET MAUI CommunityToolkit: 5.2.0 and 5.3.0
- OS: Win 10 Build 19045.3324
- .NET MAUI: 
runtimes-windows           7.0.5/7.0.100          VS 17.7.33711.374
android                    33.0.46/7.0.100        VS 17.7.33711.374
maui-windows               7.0.86/7.0.100         VS 17.7.33711.374
maui-maccatalyst           7.0.86/7.0.100         VS 17.7.33711.374
maccatalyst                16.4.7060/7.0.100      VS 17.7.33711.374
maui-ios                   7.0.86/7.0.100         VS 17.7.33711.374
ios                        16.4.7060/7.0.100      VS 17.7.33711.374
maui-android               7.0.86/7.0.100         VS 17.7.33711.374

Anything else?

There is a detailed discussion about this here: #729

Supposedly, a fix was made in toolkit v5.0.0, however, I am finding that NOT to be the case, no change. Issue still persists.
See commit: 48e7831
@dapug dapug added bug Something isn't working unverified labels Sep 9, 2023
@VladislavAntonyuk
Copy link
Collaborator

it is not the size of the image. you specify Maximum image size. The image will be resized proportionally.

@dapug
Copy link
Author

dapug commented Sep 10, 2023

OK, can you please explain how it is possible then, to specify the actual size the resulting image should be? The way it is implemented right now makes it pretty much useless, as the resulting image dimensions will never be defined or able to be set (and very much needs to be).

The goal is not to capture only the minimum area containing the actual drawn lines, but the total area that the user was given to draw the lines in the first place.

@nourben
Copy link

nourben commented Jan 3, 2024 •
edited
Loading

I agree with @dapug.
By providing a size, it make sense that the goal is to get the size is the total area that the user was given to draw the lines in the first place.

Resizing the image to get only the minimum area containing the drawn line looks like a very specific case.
Not a common use case for an app using a drawingview.

@bijington
Copy link
Contributor

It does look like we have an inconsistency in our XML documentation that would lead to this confusion:

DrawingView.shared.cs

Maui/src/CommunityToolkit.Maui/Views/DrawingView/DrawingView.shared.cs

Line 218 in 02896d3

/// <param name="imageSize">The desired dimensions of the generated image. The image will be resized proportionally.</param>

DrawingViewService.macios.cs

Maui/src/CommunityToolkit.Maui.Core/Views/DrawingView/Service/DrawingViewService.macios.cs

Line 16 in 02896d3

/// <param name="imageSize">Maximum image size. The image will be resized proportionally.</param>

I can personally see a benefit for both use cases. I will reopen this and we can discuss it later during the standup

@bijington bijington reopened this Jan 4, 2024
@bijington bijington added the needs discussion Discuss it on the next Monthly standup label Jan 4, 2024
@VladislavAntonyuk
Copy link
Collaborator

The keyword here is Desired. So to make it clear size 200x200 is the maximum size of the image. but because drawing image may differ (e.g. 100x300), we proportionally change your size to this. So the final size is approximately 66x200.

@dapug
Copy link
Author

dapug commented Jan 5, 2024 •
edited
Loading

The keyword here is Desired. So to make it clear size 200x200 is the maximum size of the image. but because drawing image may differ (e.g. 100x300), we proportionally change your size to this. So the final size is approximately 66x200.

I have no problem with that functionality, BUT...

The API provides NO way to access the 66x200 resulting dimensions, and therefore one cannot, ever, reconstitute the 200x200 (or 100x300, etc) original image and place the lines appropriately in it as it was when drawn. So the result does indeed do as you said, but ultimately is useless in real life application because one cannot ever retain the original backdrop/canvas size, nor can we even know what the dimension result was so that we can reconstruct an image back to original ourselves.

The user of the API needs the option to:
1 - request the output to adhere to a specified size and position within that size (200x200 in this example)
2 - get the actual size output result (66x200 in the example being discussed)

@bijington bijington removed the needs discussion Discuss it on the next Monthly standup label Feb 1, 2024
@vhugogarcia vhugogarcia added area/views Issue/Discussion/PR that has to do with Views and removed unverified labels Jul 22, 2024
@ricavir11
Copy link

I agree, we should be able to get the image of the full drawingview area.

@bijington bijington linked a pull request Sep 10, 2024 that will close this issue
Open
6 tasks
@bijington
Copy link
Contributor

@dapug @nourben and @ricavir11 I have opened #2193 which include a PoC for supporting it on iOS. Do you think this would work for your needs?

@ricavir11
Copy link

@bijington : yes, this would be a good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bijington bijington

Labels
area/views Issue/Discussion/PR that has to do with Views bug Something isn't working
Projects
None yet
Milestone
No milestone
6 participants
@vhugogarcia @dapug @nourben @bijington @ricavir11 @VladislavAntonyuk