Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Search Modal Opens Over Opened Modal via Key Bindings #93

Open
duyanran100 opened this issue Feb 10, 2025 · 1 comment
Open

Global Search Modal Opens Over Opened Modal via Key Bindings #93

duyanran100 opened this issue Feb 10, 2025 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@duyanran100
Copy link

When using the global-search-modal package for Filament, it is possible to open the search modal using key bindings (e.g., Ctrl + K) even when another modal (such as a Create/Edit action modal) is already open.

Expected Behaviour:
The global search modal should not open if another modal is already active, similar to Filament’s built-in global search behaviour.

Actual Behaviour:

Image

The search modal opens underneath of the existing modal.
The existing modal becomes disabled, causing form fields to be unresponsive.

Steps to Reproduce:
Open a Create/Edit action modal in Filament.
Press Key bindings (Ctrl + K for me) to open the global search modal.
Observe that the global search modal opens overlapping the existing modal, making the previous form fields disabled.

A screen shot has been attached.

@CharrafiMed CharrafiMed added bug Something isn't working good first issue Good for newcomers labels Feb 10, 2025
@CharrafiMed
Copy link
Owner

Thank you for bringing this to my attention! I’ll work on fixing this issue. However, since the modal used by the plugin isn’t the built-in Filament modal, I’m not entirely sure if I’ll have access to the state of the Filament modal to detect whether it’s already active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants