Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Filecoin.MpoolGetNonce RPC method #5149

Open
1 task
LesnyRumcajs opened this issue Jan 16, 2025 · 2 comments
Open
1 task

Fix flaky Filecoin.MpoolGetNonce RPC method #5149

LesnyRumcajs opened this issue Jan 16, 2025 · 2 comments
Labels
Type: Task Discrete task to implement

Comments

@LesnyRumcajs
Copy link
Member

Summary

Note - the fix might not be trivial as there are several open issues for mpool. See https://github.com/ChainSafe/forest/issues?q=is%3Aissue%20state%3Aopen%20mpool

We currently have this method suppressed - it would be great to at least attach some logs to the issue once replicated.

Completion Criteria

  • Method is present in tests and is not flaky

Additional Links & Resources

@LesnyRumcajs LesnyRumcajs added the Type: Task Discrete task to implement label Jan 16, 2025
@LesnyRumcajs LesnyRumcajs moved this from New to Ready in Forest Backlog 🌲 Jan 16, 2025
@hanabi1224
Copy link
Contributor

This method seems to be deprecated, see https://github.com/filecoin-project/lotus/blob/v1.31.0/documentation/en/api-v1-unstable-methods.md#mpoolgetnonce.

MpoolGetNonce gets next nonce for the specified sender. Note that this method may not be atomic. Use MpoolPushMessage instead.

Also, when I run api compare locally, the lotus API keeps throwing errors.

| RPC Method             | Forest | Lotus                                              |
|------------------------|--------|----------------------------------------------------|
| Filecoin.MpoolGetNonce | Valid  | Rejected("ID address not found in lookback state") |
Error: Some tests failed

@LesnyRumcajs
Copy link
Member Author

I don't see mention of deprecation; it's just that it's not atomic. Most users would likely not want to use it, but there might be some nice cases. It's also in the Common Node API spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task Discrete task to implement
Projects
Status: Ready
Development

No branches or pull requests

2 participants