Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Thrown exceptions are silenced by default #21

Open
eliashaeussler opened this issue Nov 1, 2021 · 0 comments
Open

[BUG] Thrown exceptions are silenced by default #21

eliashaeussler opened this issue Nov 1, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@eliashaeussler
Copy link
Member

eliashaeussler commented Nov 1, 2021

Description
All thrown exceptions are currently silenced by AbstractDataProcessor::process(). This leads to the fact that thrown exceptions result in log entries only instead of showing them in the Frontend (by making use of TYPO3's exception handlers).

Steps to reproduce

  1. Enforce your code to fail
  2. Check output in Frontend
  3. Remove try/catch in AbstractDataProcessor::process()
  4. Check output in Frontend

Expected behavior
Thrown exceptions should never be silenced as this makes it hard to find and solve problems in the codebase. Instead, TYPO3's exception handler (or any custom registered exception handler) should be used to handle exceptions the standard way.

Environment

  • TYPO3 version: all supported versions
  • Handlebars version: all versions
  • Composer Mode: not relevant
  • OS: not relevant

Additional context
No.

@eliashaeussler eliashaeussler added the bug Something isn't working label Nov 1, 2021
@eliashaeussler eliashaeussler self-assigned this Nov 1, 2021
@eliashaeussler eliashaeussler added this to the v0.8.0 milestone Nov 1, 2021
@eliashaeussler eliashaeussler modified the milestones: v0.8.0, v1.0 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant