-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReportStream ORM/OML Transformations Losing Data #900
Comments
While reviewing AL test order scenarios output, I found that these fields were missing in the output OML |
Original list of missing fields: - OBX-3
|
PR in RS: CDCgov/prime-reportstream#15910. The PR has been merged into this branch: |
This is the E2E output of the sample message linked in the summary when run against the
|
ReportStream HL7 to FHIR output of https://github.com/CDCgov/trusted-intermediary/tree/main/examples/MN/003_MN_ORM_O01_NBS.hl7 when run on the OML-Updates-Base feature branch: |
I submitted
|
The 2nd OBR is being dropped because 003_MN_ORM_O01_NBS.hl7 isn't a valid ORM per HL7 V2.5.1.
|
Submitting the LA example
|
additional information regarding above:
|
@GilmoreA6 Is going to make a new ticket for the NK1 work listed above. What is the plan for receiver transform "etor-oml-receiver-transform.yml" changes? Is that needed to close out this ticket? |
@brick-green good point. We need to figure out if we need that transformation for OBR-11 |
@brick-green Confirmed that we should remove that transformation, so that task should be part of this ticket |
@basiliskus @GilmoreA6 Can you add that task above? Can you also review the other tasks and check off the ones that are complete? |
@brick-green added it |
@brick-green there is a task "Look into possibility of adding assertions in the RS Integration Test framework to catch mapping issues" to me that also seems like a separate issue, since this ticket is specifically about validating the RS mappings and reporting gaps, thoughts? |
The integration testing will be broken out into a new ticket(s). Remaining work is removing the transformation file. |
Added this PR in RS to remove the |
Discussed in Stream 2 Refinement in relation to #472; we're assuming at this point that SPM will be provided, which would provide an alternate means of getting the info from OBR-15. |
PR to remove |
Moving back to Review / QA until the ReportStream work has been merged (to main) and deployed to staging. |
@JohnNKing If not yet captured, we need stories created for:
|
NK1 work is outlined in #1547 |
@jbiskie Did you or someone else try changing the MSH.9 to OML then seeing what happens? |
@GilmoreA6 Am I recalling correctly that you talked about doing this? |
@brick-green @jbiskie yes, although I'm not sure what it tells us other than OML message mapping exists and works. We received new test messages today from Ochsner which appear a lot more valid than the previous test messages (segments are in the correct order), so we should see what is missing by running those through as ORMs and OMLs. |
Putting the new LA order ORM messages through ReportStream changing MSH-9 from "ORM_001^ORM_001" to "OML^O21^OML_O21" results in an OML message that is complete except for the following missing segments/fields: Missing Segments: Missing Fields The missing fields are mostly (if not entirely) due to them not existing in the HL7 v2 2.5.1 standards |
Bug
Describe the Bug
ReportStream's ORM to FHIR and FHIR to OML transformations are losing data from a variety of fields, including:
I suspect this was introduced by: CDCgov/prime-reportstream#12718
For more details, see https://slack.com/archives/C048S3GPSQG/p1707861774688789
Also ensure an error isn't caused when the order has no OBX segments. (i.e. make OBX not required for ORM messages). Potentially relevant: https://github.com/CDCgov/prime-reportstream/blob/0eb5b42c5a8ccb2d7876fbee7441c790eaf5b828/prime-router/src/main/resources/metadata/hl7_mapping/OML_O21/OML_O21-base.yml#L62
Recently transformed ORM (from 9/11/2024): https://www.slack.com/archives/C044P2CBEKS/p1726088886147019?thread_ts=1726088335.991899&cid=C044P2CBEKS
Impact
ORM orders are lacking key pieces of information for NBS.
To Reproduce
Expected Behavior
Expected HL7 output should be the following (or equivalent):
Tasks
- [ ] Look into possibility of adding assertions in the RS Integration Test framework to catch mapping issuesScreenshots
n/a
Logs
n/a
Version
Current master branch
Additional Context
n/a
The text was updated successfully, but these errors were encountered: