Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyrenew_h forecasts to large parquet hubverse table #350

Open
dylanhmorris opened this issue Feb 13, 2025 · 1 comment
Open

Add pyrenew_h forecasts to large parquet hubverse table #350

dylanhmorris opened this issue Feb 13, 2025 · 1 comment
Assignees

Comments

@dylanhmorris
Copy link
Contributor

dylanhmorris commented Feb 13, 2025

Currently not included

I think the bug is that it is incorrectly classified as "daily" so it gets removed in this filter:

dplyr::filter(.data$resolution == "epiweekly") |>

See also #330

@damonbayer
Copy link
Collaborator

damonbayer commented Feb 13, 2025

  1. I agree that this is the reason the H forecasts are not in the hubverse table.
  2. I would like to move away from "daily" and "epiweekly" language to "unaggregated" and "aggregated."
  3. I don't think we can use forecasttools as-is to produce this table, as it makes strong assumptions about the output being epiweekly, but more investigation is needed. One problem with this is calculating forecast horizon for daily vs weekly forecass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants