New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved clarity for nbbp vignette #7

Open

cherz4 opened this issue Feb 10, 2025 · 1 comment · May be fixed by #12

cherz4 commented Feb 10, 2025

Based on comment in PR #6 , #6 (comment)

To improve clarity and understanding for the reader of the nbbp vignette, could you address the following?

I was a little confused by the explanation of the likelihood surface plot and the second image that zoomed in on the ridge. What was the reader supposed to take away from this?
Fleshing out the R distribution overlap text in the measles comparison would be helpful for the reader to better follow your calculations.
I see no divergent transitions in the MERS-CoV example - is this text outdated (given you are running with a seed)?

cherz4 mentioned this issue

Advanced documentation #6

Merged

afmagee42 mentioned this issue

Math (and other) issues in the R = 0 case #11

Open

afmagee42 added a commit that referenced this issue


          resolve #7

98835d5

afmagee42 linked a pull request

that will close this issue

Open

Collaborator

afmagee42 commented Feb 13, 2025

These are really good points! The text on both of those first two definitely needed some reworking. This should be fixed in #12.

afmagee42 linked a pull request

that will close this issue

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment