Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress only some warnings in PMF formatting #31

Open
Tracked by #182
zsusswein opened this issue Sep 11, 2024 · 2 comments
Open
Tracked by #182

Suppress only some warnings in PMF formatting #31

zsusswein opened this issue Sep 11, 2024 · 2 comments
Labels

Comments

@zsusswein
Copy link
Collaborator

zsusswein commented Sep 11, 2024

For EpiNow2 in the *_format() functions.

I originally wrote:

I also want to flag this choice as a to-discuss. EpiNow2 throws a "once every 8 hours" warning about the change in the use of the max argument. This warning gets thrown every time on CI and causes a failing R CMD check.

I had trouble getting rlang::try_fetch() to downgrade the warning to a message, so I gave up and just suppressed the warning.

I think this choice is reasonable because we're running on a pinned version of the package. We should be able to catch any issues in a managed upgrade on CI. But if we for some reason think interactive use with multiple versions of EpiNow2 is needed, we should revisit this choice.

We landed on:

Yes seems correct that 1. We don't want to get this warning 2. We do want to get other warnings (probably). As to how to achieve that technically I'm unsure

Originally posted by @athowes in #26 (comment)

@athowes
Copy link
Collaborator

athowes commented Sep 12, 2024

Presumably one could regex that specific warning and stop it (and let others through) but that seems quite an ugly solution.

@zsusswein
Copy link
Collaborator Author

We should follow the procedure I worked out here: https://github.com/CDCgov/cfa-gam-rt/blob/409060c906664b412d2b427d033ea18ae6633329/R/predict.R#L673

@zsusswein zsusswein added v0.3.0 and removed v0.2.0 labels Jan 29, 2025
@zsusswein zsusswein mentioned this issue Jan 29, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants