Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Fix bottom overflow issue in SnoozeDurationTile #667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahendra-918
Copy link
Contributor

@mahendra-918 mahendra-918 commented Feb 6, 2025

Description

This PR fixes the bottom overflow issue in the SnoozeDurationTile widget by ensuring the content is scrollable and properly constrained within the dialog. The changes include:

  • Wrapping the dialog content in a SingleChildScrollView.
  • Using ConstrainedBox to limit the maximum height of the dialog content.
  • Setting mainAxisSize: MainAxisSize.min for the Column.

Additionally, it ensures the initial value for the NumberPicker is within the valid range to prevent assertion errors.

Proposed Changes

Updated the snooze_duration_tile.dart file to handle overflow and assertion errors.

Fixes #665

Replace 665 with the issue number which is fixed in this PR

Screenshots

REC-20250206165936.mp4
REC-20250206130920.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@mahendra-918
Copy link
Contributor Author

hii @MarkisDev can you please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Bottom Overflow Error in Snooze Duration Modal
2 participants