Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add custom presets to Timer. #656

Open
Vardhan-ysh opened this issue Jan 29, 2025 · 6 comments
Open

Feature: Add custom presets to Timer. #656

Vardhan-ysh opened this issue Jan 29, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request feat

Comments

@Vardhan-ysh
Copy link
Contributor

Description

Timer currently only allows 4 predefined presets (1min, 5min, 10min, 15min). We can give user the ability to add custom presets.

Screenshots

@Vardhan-ysh
Copy link
Contributor Author

I would like to work on this.

@MarkisDev
Copy link
Collaborator

Hey! Sure, could you give us a clearer idea on how you plan on implementing this so we can be on the same page?

@Vardhan-ysh
Copy link
Contributor Author

Vardhan-ysh commented Feb 5, 2025

@MarkisDev , sure. I currently have in mind to implement something like this

WhatsApp.Video.2025-02-05.at.22.44.42_d96cfcc1.mp4

I will keep the UI similar to the theme of ultimate alarm clock. This video just shows what I am working on. I am storing the created timer presets locally using the model.

I am currently already working on this and will share the UI and working before raising a pr.

@ganidande905
Copy link
Contributor

Hey @Vardhan-ysh this is already included in the application, when you click on the timer icon you will be displayed with option to set custom timer, I don't think this would be needed
@MarkisDev what's your opinion on this?

@Vardhan-ysh
Copy link
Contributor Author

@ganidande905 Yes, but you cannot add a custom preset. Only the predetermined 1, 5,10, and 15 minutes is present. For example if we need to set a 1 hour 30 min timer everyday, we would need to dial that number in everytime instead of setting a preset of 1 hour 30 min that we can use.I think adding this would make it more convenient than adding the same timer everytime.

@MarkisDev
Copy link
Collaborator

@Vardhan-ysh You can go ahead with the custom preset implementation. Would be a good addition to set quick timers. Please ensure you follow the same UI.

@MarkisDev MarkisDev added the enhancement New feature or request label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat
Projects
None yet
Development

No branches or pull requests

3 participants