Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I updated this including all fixes by maikramer and finepointcgi #38

Open
ParkingLotGames opened this issue Jan 14, 2023 · 6 comments
Open

Comments

@ParkingLotGames
Copy link

I have been updating Materialize from the last build finepointcgi made, which was around 2020-21 and included all the fixes and contributions by maikramer as well.

It now uses Unity 2019.4.40f1 as base (using 2020 causes shader compilation issues).
The backend has been changed to IL2CPP for Linux and Win x64. I don't have a mac so I can't make a IL2CPP mac build, only Mono.
Win x86 will continue using Mono at the moment, this is because finepointcgi replaced the file explorer with a native popup, causing crashes on IL2CPP x86.
Among other QOL improvements I enabled the Incremental GC and bumped the version no. to 1.4.0

I am also re-implementing the UI to be more user friendly and have a better distribution
https://github.com/ParkingLotGames/Materialize2019-by-finepointcgi

@Batowski
Copy link

Batowski commented Feb 28, 2023

Using the X64 version of your changes on Win11 and it crashes when I click the open button on any material.
X86 Mono version can load images, but File and Hide UI buttons are not clickable.

@ParkingLotGames
Copy link
Author

Using the X64 version of your changes on Win11 and it crashes when I click the open button on any material. X86 Mono version can load images, but File and Hide UI buttons are not clickable.

will check this, sorry for the delay I didn't see it until today.
I don't have an 11 machine but I can make a VM to try and replicate it, thanks

@TailwagDeveloper
Copy link

@ParkingLotGames Tried your latest release, but it doesn't work. Notably, the file tab has no functionality. Opened in unity 2019.4.40 as well and there are a lot of missing references to scripts and other objects in the inspector. Do you have any insights regarding these issues?

@ParkingLotGames
Copy link
Author

@ParkingLotGames Tried your latest release, but it doesn't work. Notably, the file tab has no functionality. Opened in unity 2019.4.40 as well and there are a lot of missing references to scripts and other objects in the inspector. Do you have any insights regarding these issues?

If I recall correctly several of those scripts were missing already from finepoint's last commit. I found several missing scripts indeed all under "MainGui", I believe most of these were removed as they were originally written in imGui and finepoint updated it to UGUI, I assume he deleted it and never reimplemented it. going to look into maikramer's, and finepoint's commits to see if I can track the missing script and add its functionality back.

@ParkingLotGames
Copy link
Author

Using the X64 version of your changes on Win11 and it crashes when I click the open button on any material. X86 Mono version can load images, but File and Hide UI buttons are not clickable.

as for this issue I have found an unhandled error when canceling an open dialog but you mentioned crashing directly after clicking open, which I will try to reproduce, but will implement error handling for what I just found in the meantime.

@Batowski
Copy link

as for this issue I have found an unhandled error when canceling an open dialog but you mentioned crashing directly after clicking open, which I will try to reproduce, but will implement error handling for what I just found in the meantime.

I can't really comment on this, only that I specifically remember that clicking on the open button crashed the app. It was unusable so I haven't touched it since. Let me know if you want me to test anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants