Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLOPE rounding error #1

Open
michbur opened this issue Nov 8, 2021 · 1 comment
Open

SLOPE rounding error #1

michbur opened this issue Nov 8, 2021 · 1 comment
Assignees

Comments

@michbur
Copy link
Member

michbur commented Nov 8, 2021

Rounding errors in SLOPE depend on the OS (https://github.com/BioGenies/SLOPE/blob/master/src/SLOPE.cpp#L23).

@KrystynaGrzesiak
Copy link

KrystynaGrzesiak commented Nov 10, 2021

We tested trainSLOPE and it turned out that the results slightly differ between operating systems.

All the operating systems encounter differences between the expected and obtained values. It can be seen in the check that the obtained differences vary depending on OS (even in order of magnitude). Hence Windows fails one test while ubuntu and macOS fail two of them.

The differences probably come from rounding in cpp. It may be fixed temporarily by additional tolerance in expect_equal.

KrystynaGrzesiak added a commit that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants