Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calva.prettyPrintingOptions.maxDepth breaks Calva Inspector #2701

Open
skylize opened this issue Jan 8, 2025 · 2 comments
Open

calva.prettyPrintingOptions.maxDepth breaks Calva Inspector #2701

skylize opened this issue Jan 8, 2025 · 2 comments
Labels
configuration pprint Pretty printing issues

Comments

@skylize
Copy link
Contributor

skylize commented Jan 8, 2025

Having any value for calva.prettyPrintingOptions.maxDepth causes zprint to error out. This results in a broken UI for Calva Inspector, which can't create folding and hover features without the pretty printed output.

@PEZ
Copy link
Collaborator

PEZ commented Jan 8, 2025

Technically it doesn't cause zprint to error out. 😄 If you ask zprint to use zero depth it will use zero depth. It's a valid setting.

Not sure how it should be addressed. The description of the maxDepth setting does say that unlimited depth is unlocked by not including the key. It could also mention that 0 is not how this is achieved. And that 0 makes the inspector boring. Also we should update the docs site about it.

@PEZ PEZ added pprint Pretty printing issues configuration labels Jan 8, 2025
@skylize
Copy link
Contributor Author

skylize commented Jan 13, 2025

Not sure how depth: 0 got into my settings. But my guess is it's for puget, which I've been running for a while. So makes it a cross-compatibility issue, from having multiple provider choices.

When posting the issue, I had some sort of real code fix in mind. But thinking through again, I see no good reason why it needs any more than a just note in the docs that it will break the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration pprint Pretty printing issues
Projects
None yet
Development

No branches or pull requests

2 participants