Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Recoverable Resources #180

Open
TonyWildish-BH opened this issue Oct 10, 2024 · 0 comments
Open

Non-Recoverable Resources #180

TonyWildish-BH opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working EPIC - Pen-test fixes Fixing security issues found during penetration testing MVP Things that need to be considered for the MVP release

Comments

@TonyWildish-BH
Copy link
Collaborator

The penetration testing report showed that (page 40):

A number of resources were identified that did not benefit from protection against accidental or intentional deletion. This could result in disruption to business operations.

Ensure that production Azure KeyVaults are recoverable in order to prevent permanent deletion/purging of encryption keys, secrets and certificates stored within these vaults. To make an Azure KeyVault or Storage Account instance recoverable, both "Soft Delete" and "Do Not Purge" features should be enabled.

  • "Soft Delete", implemented by enableSoftDelete parameter, ensures that even if the KeyVault is deleted, the vault itself or its objects (keys, secrets, certificates) remain recoverable for next 90 days
  • "Do Not Purge" feature, implemented by enablePurgeProtection parameter, ensures that the Azure Key Vault and its objects cannot be purged at all, preventing users from accidentally purging Azure KeyVault resources.

It was also noted that Storage Accounts were also configured without Soft-Delete, rendering their contents susceptible to accidental or intentional deletion.

N.B. The first action here is to review the list of affected resources (see the pen-test report), then decide what action is appropriate in each case. So this may spin out into a number of tickets, depending on what's required for each object type.

For KeyVaults, some of these configuration parameters are surfaced in the top-level config.yaml.

This is a medium level risk, but is something we must fix before the next pen-test.

@TonyWildish-BH TonyWildish-BH added bug Something isn't working MVP Things that need to be considered for the MVP release EPIC - Pen-test fixes Fixing security issues found during penetration testing labels Oct 10, 2024
@TonyWildish-BH TonyWildish-BH self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EPIC - Pen-test fixes Fixing security issues found during penetration testing MVP Things that need to be considered for the MVP release
Projects
None yet
Development

No branches or pull requests

1 participant