Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

Make 'request.Timespan' & 'request.Interval' Configurable #62

Open
goodinfoconsulting opened this issue Feb 21, 2019 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@goodinfoconsulting
Copy link

Please make the 'request.Timespan' & 'request.Interval' (found in azure-k8s-metrics-adapter/pkg/azure/appinsights/appinsights.go) configurable for end users. Through a helm install param or a yaml file or something like that.

I have a scenario where we are unable to collect metrics because the metrics interval specified is too small.

@jsturtevant
Copy link
Collaborator

I believe the best place for this would be to update the custom metric CRD, so it could be configured per metric.

@jsturtevant jsturtevant added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 22, 2019
@webthaumaturge
Copy link

And can request.Filter (also in azure-k8s-metrics-adapter/pkg/azure/appinsights/appinsights.go) be configurable too please. I'd like to filter on a custom dimension.

That sounds great to make these parameters of the custom metric CRD so that they're configured per metric.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants