From bbf6b42cd34430e32a34bf426bd55fa494b93503 Mon Sep 17 00:00:00 2001 From: sinedied Date: Wed, 22 May 2024 16:53:16 +0200 Subject: [PATCH 1/2] fix: fail the upload script if an error occur --- scripts/upload-documents.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/upload-documents.js b/scripts/upload-documents.js index 7ec482e..6303a6e 100644 --- a/scripts/upload-documents.js +++ b/scripts/upload-documents.js @@ -26,12 +26,17 @@ async function uploadDocuments(apiUrl, dataFolder) { }); const responseData = await response.json(); - console.log(responseData); + if (response.ok) { + console.log(responseData); + } else { + throw new Error(responseData.error); + } } } /* eslint-enable no-await-in-loop */ } catch (error) { console.error(`Could not upload documents: ${error.message}`); + process.exitCode = -1; } } From 1f8acb1291c6dc3af4ff7e7644126a4e95b8bcca Mon Sep 17 00:00:00 2001 From: Yohan Lasorsa Date: Thu, 23 May 2024 08:51:42 +0000 Subject: [PATCH 2/2] refactor: improve upload logging --- scripts/upload-documents.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/upload-documents.js b/scripts/upload-documents.js index 6303a6e..8090524 100644 --- a/scripts/upload-documents.js +++ b/scripts/upload-documents.js @@ -10,7 +10,9 @@ import path from 'node:path'; // ``` async function uploadDocuments(apiUrl, dataFolder) { try { + const uploadUrl = `${apiUrl}/api/documents`; const files = await fs.readdir(dataFolder); + console.log(`Uploading documents to: ${uploadUrl}`); /* eslint-disable no-await-in-loop */ for (const file of files) { @@ -20,14 +22,14 @@ async function uploadDocuments(apiUrl, dataFolder) { const formData = new FormData(); formData.append('file', new File(blobParts, file)); - const response = await fetch(`${apiUrl}/api/documents`, { + const response = await fetch(uploadUrl, { method: 'post', body: formData, }); const responseData = await response.json(); if (response.ok) { - console.log(responseData); + console.log(`${file}: ${responseData.message}`); } else { throw new Error(responseData.error); }