Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To-Do improvements #40

Closed
13 tasks done
luisquintanilla opened this issue Apr 21, 2023 · 4 comments
Closed
13 tasks done

To-Do improvements #40

luisquintanilla opened this issue Apr 21, 2023 · 4 comments

Comments

@luisquintanilla
Copy link
Collaborator

luisquintanilla commented Apr 21, 2023 •
edited
Loading

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
@IEvangelist IEvangelist mentioned this issue Apr 24, 2023
Merged
@IEvangelist
Copy link
Member

For the last task in this list @luisquintanilla, I did work on that in my initial PR. Here is the PR where we want from a 79 to 95 rating: 00408c8. Do you have a specific target?

IEvangelist added a commit that referenced this issue Apr 24, 2023
@IEvangelist
Update Image Creator generated images to not include faces (#42)
cfaf59b 
Address concerns with generated images, contributes to #40.
@IEvangelist IEvangelist mentioned this issue Apr 25, 2023
Merged
@luisquintanilla
Copy link
Collaborator Author

For the last task in this list @luisquintanilla, I did work on that in my initial PR. Here is the PR where we want from a 79 to 95 rating: 00408c8. Do you have a specific target?

Thanks! 95 is great. Are the changes merged yet or is there a branch I can use to preview the changes? The images look good. Thanks for updating those.

IEvangelist added a commit that referenced this issue Apr 25, 2023
@IEvangelist
Rewrite the scripts to be a .NET command line app (#43)
a0a995b 
Rewrite the scripts to be a .NET command line app, contributing to #40
and fixes #20.

Replaces the original
[`prepdocs.py`](https://github.com/Azure-Samples/azure-search-openai-demo-csharp/blob/cfaf59b953835c6c309cda74e7a72aec427695e6/scripts/prepdocs.py)
@IEvangelist IEvangelist mentioned this issue Apr 26, 2023
Merged
@IEvangelist
Copy link
Member

For the last task in this list @luisquintanilla, I did work on that in my initial PR. Here is the PR where we want from a 79 to 95 rating: 00408c8. Do you have a specific target?

Thanks! 95 is great. Are the changes merged yet or is there a branch I can use to preview the changes? The images look good. Thanks for updating those.

Hi @luisquintanilla - these changes have been in place since the .NET frontend bits were merged.

IEvangelist added a commit that referenced this issue Apr 26, 2023
@IEvangelist
Address response latency concerns on api/ask endpoint (#44)
7a233d7 
In this PR:

- Added in-memory caching of `api/ask` endpoint, for each unique request
(30 mins).
- Renamed DI extensions, and scope to `IServiceCollections` rather than
`builder`.
- Minor formatting, logging updates and cleanup.
- Created conditional style component for dynamic `HeadContent` styles.

Contributes to #40
@IEvangelist IEvangelist mentioned this issue Apr 27, 2023
Merged
IEvangelist added a commit that referenced this issue Apr 27, 2023
@IEvangelist
Convert the client app over from standalone to hosted (#57)
90c6702 
Convert the client app over from standalone to hosted, contributes to
#40. Fixes #58.
@IEvangelist IEvangelist mentioned this issue Apr 27, 2023
Merged
IEvangelist added a commit that referenced this issue Apr 27, 2023
@IEvangelist
Replace in-memory caching, with Redis caching. (#59)
dd034b4 
Replace in-memory caching, with Redis caching. Contributes to #40, and
fixes #60.
@luisquintanilla
Copy link
Collaborator Author

Closing in favor of #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IEvangelist @luisquintanilla