Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyVault secrets are passed to module w/o secure() decorator. #222

Open
jongio opened this issue Nov 2, 2023 · 6 comments
Open

KeyVault secrets are passed to module w/o secure() decorator. #222

jongio opened this issue Nov 2, 2023 · 6 comments
Assignees

Comments

@jongio
Copy link
Member

jongio commented Nov 2, 2023

This app creates secrets in bulk, but passes those secrets from main.bicep w/o using the secure decorator. Those secrets with therefore be in plaintext in the Azure deployment.

Add secure() here.

If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure decorator on the key.

@LittleLittleCloud
Copy link
Collaborator

image

@LittleLittleCloud
Copy link
Collaborator

@jongio Can you share an example on adding secure decorator to individual module?

@jongio
Copy link
Member Author

jongio commented Nov 8, 2023

I'd go this route:

If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure decorator on the key.

@luisquintanilla
Copy link
Collaborator

I'd go this route:

If that isn't possible, then remove the keyvault-secrets.bicep file and create them with individual module references and a secure decorator on the key.

@jongio do we have a sample of this?

@luisquintanilla
Copy link
Collaborator

@LittleLittleCloud are we okay to close this one?

@jongio
Copy link
Member Author

jongio commented Jan 2, 2024

I'd remove "secrets" file and set each one individually so they are passed securely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants