Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarization accepatance criteria #6

Open
23 of 25 tasks
anfibiacreativa opened this issue Apr 29, 2024 · 0 comments
Open
23 of 25 tasks

Standarization accepatance criteria #6

anfibiacreativa opened this issue Apr 29, 2024 · 0 comments
Assignees
Labels
msstandarization Acceptance criteria checklist
Milestone

Comments

@anfibiacreativa
Copy link
Member

anfibiacreativa commented Apr 29, 2024

The following checklist must be complete before a template is published.

Repository Management

Source code structure and conventions

  • GitHub Actions (This refers to .github/workflows/azure-dev.yml or custom workflow to run on a GitHub runner) is in place
  • DevContainer (/.devcontainer folder where applicable) configuration is in place
  • Infrastructure as code is in place (/infra folder where applicable, manifest files or code generators in the case of Aspire and similar )
  • Azure services configuration (/azure.yml file) is in place
  • Minimum coverage tests are in place

Functional requirements

  • azd up successfully provisions and deploys a functional app
  • GitHub Actions run tasks without errors
  • DevContainer has been tested locally and runs
  • Codespaces run [locally and in browser]
  • All tests pass

In the absence of e2e tests,

  • The application has been manually tested to work as per the requirement

Security requirements

When a service selected doesn't support Managed Identity, the corresponding issue must have been reported and the security considerations section in the readme, should clearly explain the alternatives.

  • Azure Key Vault is a preferred alternative

The following items are not strictly enforced but may prevent the template from being added to the gallery.

Project code follows standard structure, per language. Please check one.

  • Yes, follows standards
  • No, doesn't follow standards

Code follows recommended style guide

  • Yes, follows style guide
  • No, doesn't follow style guide
@anfibiacreativa anfibiacreativa added the msstandarization Acceptance criteria checklist label Apr 29, 2024
@anfibiacreativa anfibiacreativa added this to the Build 2024 milestone Apr 29, 2024
manekinekko added a commit that referenced this issue May 6, 2024
manekinekko added a commit that referenced this issue May 6, 2024
@manekinekko manekinekko reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msstandarization Acceptance criteria checklist
Projects
None yet
Development

No branches or pull requests

3 participants