Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Multiple panes cause incorrect errors #180

Open
jdolle opened this issue Jun 11, 2017 · 19 comments
Open

Multiple panes cause incorrect errors #180

jdolle opened this issue Jun 11, 2017 · 19 comments

Comments

@jdolle
Copy link

jdolle commented Jun 11, 2017

When working with multiple panes in Atom, tslint will give invalid errors for files and behave erratically.

@Xapphire13
Copy link
Contributor

Can you define "behave erratically"? Also, could you try with a different type of file/linter combo to see if the issue is actually linter-ui-default?

@roddypratt
Copy link

I've also seen cases where the linter shows spurious errors when using multiple panes. Demo here (sorry about crap audio) https://screencast-o-matic.com/watch/cb1o2eXRGd

Doesn't seem to happen with Atom PHP linter.

@jdolle
Copy link
Author

jdolle commented Jun 15, 2017

Sorry for the delay in responding -- I am running several linters and have not had issues with any other than tslint. It gives false errors and the error messages show incorrect values, i.e. instead of "property 'example' does not exist on type 'MyExample'", it may read "property 'ample Ev' does not exist on type 'ple And'". It is as if the linter loses its place in the file. If you need a screenshot I'll try to reproduce when I can find time.

@Xapphire13
Copy link
Contributor

@roddypratt The video you shared shows the provider is Typescript, which is this package. I have also been having this issue with the TypeScript package lately (much worse issues in fact) but haven't filled a bug. Maybe you could share your video in a bug report on that repo? For reference, the provider from this package will look like this:
image

@jdolle What does the provider field say for you?

@roddypratt
Copy link

roddypratt commented Jun 16, 2017

@Xapphire13 You're right, of course. I'm new to Atom and hadn't sussed the distinction between the two plugins. I'll move the report and video over. Thanks! (Appears to be a known year-old issue... TypeStrong/atom-typescript#869)

@jdolle
Copy link
Author

jdolle commented Jun 19, 2017

@Xapphire13 TSLint. It happened again to my coworker so I got screenshots.

This is with two panes open.
broken_multi_pane

And this is after restarting Atom.
after_restarting_atom

@Xapphire13
Copy link
Contributor

I've been seeing this a little bit recently, but not isolated to linter-tslint (seen it with atom-typescript also). I think this may be an issue with linter-ui

@mehcode
Copy link

mehcode commented Jul 11, 2017

Just to rule out the linter-ui, go ahead and test using linter-ui-plus to see if you have the same problem. If you have the same problem it's likely not the linter-ui.

@Xapphire13
Copy link
Contributor

I personally don't have a constant repro, @jdolle, is yours 100% repro?

@Xapphire13
Copy link
Contributor

One interesting thing to note is that the lint issue list seems to be correct each time, just the in-editor indicators

@mehcode
Copy link

mehcode commented Jul 11, 2017

Oh. That actually explains a great deal. How are you seeing the problem? Is it after some plugin rewrites a bunch of a text in the editor?

@mehcode
Copy link

mehcode commented Jul 11, 2017

prettier/prettier-atom@9a538e1

This might be related.

@Xapphire13
Copy link
Contributor

I see the issue when i bulk delete a number of lines from one pane, then the atom-typescript package triggers static analysis, once that's done, the analysis results are messed up in one of the panes.

@Arcanemagus
Copy link
Member

Hmmm, so the same file is open in multiple panes, editor markers are correct for the "active" pane, but the other pane the highlighting is wrong?

@Xapphire13
Copy link
Contributor

As I recall (from my repros), yes. Though next time it happens for me I will take screenshots of my own so it's not just from memory =]

@jdolle
Copy link
Author

jdolle commented Jul 12, 2017

@Xapphire13 I cannot reproduce it consistently. And I also get similar incorrect errors sometimes from Atom-Typescript so it may be an issue with the linter UI. The inconsistency makes it hard to know. Sorry I'm not much help.

@mxchange
Copy link

mxchange commented Aug 25, 2017

This is still an issue, I'm using atom-typescript, linter, linter-tslint & linter-ui-default.
It's hard to reproduce, but seems to have to do with multiple panes, and only restarting Atom will fix it.
Most times, a type error will occur, and when fixed, will still show red underlines, and often create new errors which are incorrect errors, on the wrong line, referring to other lines somehow.

@mxchange
Copy link

Example:

image

@Xapphire13
Copy link
Contributor

At this point im convinced the issue is not linter-tslint since most of the reports show this is happening for the atom-typescript package. I think the real issue is within linter-ui-default and have an open bug here.

Could people use that bug to add details from this point?

@AtomLinter AtomLinter locked and limited conversation to collaborators Aug 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants