From 50e9b98d0ebd2bb50345b8c09e090a0b9bebef88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Monsen?= Date: Thu, 10 Oct 2024 16:06:25 +0200 Subject: [PATCH 1/6] fix: add display block forced style --- src/forceHiddenStyles.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/forceHiddenStyles.ts b/src/forceHiddenStyles.ts index 288160e9..3f90a800 100644 --- a/src/forceHiddenStyles.ts +++ b/src/forceHiddenStyles.ts @@ -8,6 +8,7 @@ const HIDDEN_TEXTAREA_STYLE = { 'z-index': '-1000', top: '0', right: '0', + display: 'block', } as const; const forceHiddenStyles = (node: HTMLElement) => { From 71036795285efc093d65151aebb8e3b4092c650f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Monsen?= Date: Thu, 10 Oct 2024 16:12:39 +0200 Subject: [PATCH 2/6] fix: log for debugging --- src/forceHiddenStyles.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/forceHiddenStyles.ts b/src/forceHiddenStyles.ts index 3f90a800..7bb7450c 100644 --- a/src/forceHiddenStyles.ts +++ b/src/forceHiddenStyles.ts @@ -12,6 +12,7 @@ const HIDDEN_TEXTAREA_STYLE = { } as const; const forceHiddenStyles = (node: HTMLElement) => { + console.log('forceHiddenStyles'); Object.keys(HIDDEN_TEXTAREA_STYLE).forEach((key) => { node.style.setProperty( key, From c387c76699c14f8d0db8c6713522ae17a6e66d31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Monsen?= Date: Thu, 10 Oct 2024 16:22:58 +0200 Subject: [PATCH 3/6] mor log --- src/calculateNodeHeight.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/calculateNodeHeight.ts b/src/calculateNodeHeight.ts index 834e43d6..2d9dfb4b 100644 --- a/src/calculateNodeHeight.ts +++ b/src/calculateNodeHeight.ts @@ -26,6 +26,7 @@ export default function calculateNodeHeight( minRows = 1, maxRows = Infinity, ): CalculatedNodeHeights { + console.log('Calculating node height'); if (!hiddenTextarea) { hiddenTextarea = document.createElement('textarea'); hiddenTextarea.setAttribute('tabindex', '-1'); From d2525a0f6d2100df4d580f815fd6625451776ecc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Monsen?= Date: Thu, 10 Oct 2024 16:25:13 +0200 Subject: [PATCH 4/6] fix: remove logs --- src/calculateNodeHeight.ts | 3 +-- src/forceHiddenStyles.ts | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/calculateNodeHeight.ts b/src/calculateNodeHeight.ts index 2d9dfb4b..c1d7ca3d 100644 --- a/src/calculateNodeHeight.ts +++ b/src/calculateNodeHeight.ts @@ -1,5 +1,5 @@ -import { SizingData } from './getSizingData'; import forceHiddenStyles from './forceHiddenStyles'; +import { SizingData } from './getSizingData'; // TODO: use labelled tuples once they are avaiable: // export type CalculatedNodeHeights = [height: number, rowHeight: number]; @@ -26,7 +26,6 @@ export default function calculateNodeHeight( minRows = 1, maxRows = Infinity, ): CalculatedNodeHeights { - console.log('Calculating node height'); if (!hiddenTextarea) { hiddenTextarea = document.createElement('textarea'); hiddenTextarea.setAttribute('tabindex', '-1'); diff --git a/src/forceHiddenStyles.ts b/src/forceHiddenStyles.ts index 7bb7450c..3f90a800 100644 --- a/src/forceHiddenStyles.ts +++ b/src/forceHiddenStyles.ts @@ -12,7 +12,6 @@ const HIDDEN_TEXTAREA_STYLE = { } as const; const forceHiddenStyles = (node: HTMLElement) => { - console.log('forceHiddenStyles'); Object.keys(HIDDEN_TEXTAREA_STYLE).forEach((key) => { node.style.setProperty( key, From fe25ed9c56684f5c3f6d63c995c7f19a1d45b4f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Monsen?= Date: Thu, 10 Oct 2024 16:30:28 +0200 Subject: [PATCH 5/6] fix: add changeset --- .changeset/two-turkeys-join.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/two-turkeys-join.md diff --git a/.changeset/two-turkeys-join.md b/.changeset/two-turkeys-join.md new file mode 100644 index 00000000..dda792f2 --- /dev/null +++ b/.changeset/two-turkeys-join.md @@ -0,0 +1,5 @@ +--- +'react-textarea-autosize': patch +--- + +Force display: block for the hidden textarea to prevent site overrides From 6cc8465ee3c268d0c0e289758aeceb54de35335a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind?= Date: Thu, 10 Oct 2024 16:45:31 +0200 Subject: [PATCH 6/6] Update .changeset/two-turkeys-join.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Mateusz Burzyński --- .changeset/two-turkeys-join.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/two-turkeys-join.md b/.changeset/two-turkeys-join.md index dda792f2..d61c104e 100644 --- a/.changeset/two-turkeys-join.md +++ b/.changeset/two-turkeys-join.md @@ -2,4 +2,4 @@ 'react-textarea-autosize': patch --- -Force display: block for the hidden textarea to prevent site overrides +Force `display: block` for the hidden textarea to prevent other styles from overriding it and thus breaking the resizing functionality