Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better !ping build stamp #2

Open
robsiemb opened this issue Oct 2, 2024 · 1 comment
Open

Better !ping build stamp #2

robsiemb opened this issue Oct 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@robsiemb
Copy link
Contributor

robsiemb commented Oct 2, 2024

The current build stamp generation returned by !ping is from a time before git, and doesn't really work right for Git.

Ideally, we'd be able to expose the current commit hash in !ping, both when it is running in production under docker, as well as during development just in the source tree. One option would be to use git describe in the later case, and somehow drop a file into the container with the current commit hash in the former.

@robsiemb robsiemb added the enhancement New feature or request label Oct 2, 2024
@robsiemb
Copy link
Contributor Author

robsiemb commented Oct 2, 2024

github.sha should have the hash during the github workflow to feed into an environment variable for the docker build. (see also https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant